versia-pub/api
2
0
Fork 0
mirror of https://github.com/versia-pub/api.git synced 2025-12-06 08:28:19 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(federation): 🐛 Correctly select the WebFinger link with the correct content-type, not just the first rel=self link

Browse source
This commit is contained in:
Jesse Wierzbinski 2024-07-17 15:03:24 +02:00
parent 88cfd005fd
commit ad7f66ebc3
No known key found for this signature in database
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
federation/requester/index.ts
View file

@ -72,6 +72,7 @@ export class FederationRequester {
* Get the user's profile link from their username. * Get the user's profile link from their username.
* @param username The username to get the profile link for. * @param username The username to get the profile link for.
* @param hostname The hostname to get the profile link for (defaults to the server's hostname). * @param hostname The hostname to get the profile link for (defaults to the server's hostname).
* @param contentType The content type of the link to get (defaults to "application/json").
* @returns The user's profile link. * @returns The user's profile link.
* @throws If the request fails or the response is invalid. * @throws If the request fails or the response is invalid.
* @example * @example
@ -83,6 +84,7 @@ export class FederationRequester {
public async webFinger( public async webFinger(
username: string, username: string,
hostname = this.serverUrl.hostname, hostname = this.serverUrl.hostname,
contentType = "application/json",
): Promise<string> { ): Promise<string> {
const result = await this.get<User>( const result = await this.get<User>(
`/.well-known/webfinger?${new URLSearchParams({ `/.well-known/webfinger?${new URLSearchParams({
@ -100,7 +102,9 @@ export class FederationRequester {
} }
// Get the first link with a rel of "self" // Get the first link with a rel of "self"
const selfLink = data.links?.find((link) => link.rel === "self"); const selfLink = data.links?.find(
(link) => link.rel === "self" && link.type === contentType,
);
if (!selfLink) { if (!selfLink) {
throw new Error( throw new Error(