From 0359ba13c494b0bf7461abb01fe0e675073f8c72 Mon Sep 17 00:00:00 2001 From: Jesse Wierzbinski Date: Thu, 13 Jun 2024 11:33:07 -1000 Subject: [PATCH] fix(api): :passport_control: Don't automatically remove trailing slashes from OIDC issuer URLs --- config/config.example.toml | 1 + packages/config-manager/config.type.ts | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/config/config.example.toml b/config/config.example.toml index ecaae938..6c44bed2 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -65,6 +65,7 @@ forced = false [[oidc.providers]] # name = "CPlusPatch ID" # id = "cpluspatch-id" +# This MUST match the provider's issuer URI, including the trailing slash (or lack thereof) # url = "https://id.cpluspatch.com/application/o/lysand-testing/" # client_id = "XXXX" # client_secret = "XXXXX" diff --git a/packages/config-manager/config.type.ts b/packages/config-manager/config.type.ts index bb19efde..e6a6378a 100644 --- a/packages/config-manager/config.type.ts +++ b/packages/config-manager/config.type.ts @@ -98,11 +98,7 @@ export const configValidator = z.object({ z.object({ name: z.string().min(1), id: z.string().min(1), - url: z - .string() - .min(1) - // Remove trailing slashes - .transform((arg) => arg.replace(/\/$/, "")), + url: z.string().min(1), client_id: z.string().min(1), client_secret: z.string().min(1), icon: z.string().min(1).optional(),