fix(api): 🐛 Correctly return empty body without content-type headers, when returning empty responses

api/api/v1/accounts/:id/roles/:role_id/index.ts

@@ -146,7 +146,7 @@ export default apiRoute((app) => {
 
         await role.linkUser(targetUser.id);
 
-        return context.newResponse(null, 204);
+        return context.body(null, 204);
     });
 
     app.openapi(routeDelete, async (context) => {
@@ -186,6 +186,6 @@ export default apiRoute((app) => {
 
         await role.unlinkUser(targetUser.id);
 
-        return context.newResponse(null, 204);
+        return context.body(null, 204);
     });
 });

api/api/v1/accounts/index.ts

@@ -337,6 +337,6 @@ export default apiRoute((app) =>
             email: email ?? "",
         });
 
-        return context.newResponse(null, 200);
+        return context.body(null, 200);
     }),
 );

api/api/v1/emojis/:id/index.ts

@@ -352,6 +352,6 @@ export default apiRoute((app) => {
 
         await db.delete(Emojis).where(eq(Emojis.id, id));
 
-        return context.newResponse(null, 204);
+        return context.body(null, 204);
     });
 });

api/api/v1/notifications/:id/dismiss.ts

@@ -68,6 +68,6 @@ export default apiRoute((app) =>
             dismissed: true,
         });
 
-        return context.newResponse(null, 200);
+        return context.body(null, 200);
     }),
 );

api/api/v1/notifications/clear/index.ts

@@ -47,6 +47,6 @@ export default apiRoute((app) =>
 
         await user.clearAllNotifications();
 
-        return context.newResponse(null, 200);
+        return context.body(null, 200);
     }),
 );

api/api/v1/notifications/destroy_multiple/index.ts

@@ -60,6 +60,6 @@ export default apiRoute((app) =>
 
         await user.clearSomeNotifications(ids);
 
-        return context.newResponse(null, 200);
+        return context.body(null, 200);
     }),
 );

api/api/v1/roles/:id/index.ts

@@ -226,7 +226,7 @@ export default apiRoute((app) => {
             visible,
         });
 
-        return context.newResponse(null, 204);
+        return context.body(null, 204);
     });
 
     app.openapi(routeDelete, async (context) => {
@@ -261,6 +261,6 @@ export default apiRoute((app) => {
 
         await role.delete();
 
-        return context.newResponse(null, 204);
+        return context.body(null, 204);
     });
 });

api/api/v2/filters/:id/index.ts

@@ -343,6 +343,6 @@ export default apiRoute((app) => {
             .delete(Filters)
             .where(and(eq(Filters.userId, user.id), eq(Filters.id, id)));
 
-        return context.newResponse(null, 204);
+        return context.body(null, 204);
     });
 });

api/inbox/index.ts

@@ -65,7 +65,7 @@ export default apiRoute((app) =>
             ip: context.env.ip ?? null,
         });
 
-        return context.newResponse(
+        return context.body(
             "Request processing initiated.\nImplement the Instance Messaging Extension to receive any eventual feedback (errors, etc.)",
             200,
         );

api/media/:hash/:name/index.ts

@@ -76,7 +76,7 @@ export default apiRoute((app) =>
         }
 
         // Can't directly copy file into Response because this crashes Bun for now
-        return context.newResponse(buffer, 200, {
+        return context.body(buffer, 200, {
             "Content-Type": file.type || "application/octet-stream",
             "Content-Length": `${file.size - start}`,
             "Content-Range": `bytes ${start}-${end}/${file.size}`,

api/media/proxy/:id.ts

@@ -85,7 +85,7 @@ export default apiRoute((app) =>
                 .get("Content-Disposition")
                 ?.match(/filename="(.+)"/)?.[1] || id.split("/").pop();
 
-        return context.newResponse(media.body, media.status as StatusCode, {
+        return context.body(media.body, media.status as StatusCode, {
             "Content-Type":
                 media.headers.get("Content-Type") || "application/octet-stream",
             "Content-Length": media.headers.get("Content-Length") || "0",

api/messaging/index.ts

@@ -43,6 +43,6 @@ export default apiRoute((app) =>
         getLogger(["federation", "messaging"])
             .info`Received message via ${chalk.bold("Instance Messaging")}:\n${content}`;
 
-        return context.newResponse(null, 200);
+        return context.body(null, 200);
     }),
 );

api/users/:uuid/inbox/index.ts

@@ -116,7 +116,7 @@ export default apiRoute((app) =>
             ip: context.env.ip ?? null,
         });
 
-        return context.newResponse(
+        return context.body(
             "Request processing initiated.\nImplement the Instance Messaging Extension to receive any eventual feedback (errors, etc.)",
             200,
         );

middlewares/bait.ts

@@ -33,7 +33,7 @@ export const bait = createMiddleware(async (context, next) => {
     if (requestIp?.address) {
         for (const ip of config.http.bait.bait_ips) {
             if (matches(ip, requestIp.address)) {
-                return context.newResponse(file.stream());
+                return context.body(file.stream());
             }
         }
     }
@@ -43,7 +43,7 @@ export const bait = createMiddleware(async (context, next) => {
 
     for (const agent of config.http.bait.bait_user_agents) {
         if (new RegExp(agent).test(ua)) {
-            return context.newResponse(file.stream());
+            return context.body(file.stream());
         }
     }
 

plugins/openid/routes/sso/:id/index.ts

@@ -201,7 +201,7 @@ export default (plugin: PluginType): void => {
                     .delete(OpenIdAccounts)
                     .where(eq(OpenIdAccounts.id, account.id));
 
-                return context.newResponse(null, 204);
+                return context.body(null, 204);
             },
         );
     });