fix(api): 🐛 Force text content-type header on all empty responses

Fixes a problem where the content-type would default to application/json

api/api/v1/accounts/:id/roles/:role_id/index.ts

@@ -146,7 +146,7 @@ export default apiRoute((app) => {
 
         await role.linkUser(targetUser.id);
 
-        return context.body(null, 204);
+        return context.text("", 204);
     });
 
     app.openapi(routeDelete, async (context) => {
@@ -186,6 +186,6 @@ export default apiRoute((app) => {
 
         await role.unlinkUser(targetUser.id);
 
-        return context.body(null, 204);
+        return context.text("", 204);
     });
 });

api/api/v1/accounts/index.test.ts

@@ -34,6 +34,7 @@ describe(meta.route, () => {
         });
 
         expect(response.ok).toBe(true);
+        expect(response.headers.get("Content-Type")).not.toContain("json");
     });
 
     test("should refuse invalid emails", async () => {

api/api/v1/accounts/index.ts

@@ -337,6 +337,6 @@ export default apiRoute((app) =>
             email: email ?? "",
         });
 
-        return context.body(null, 200);
+        return context.text("", 200);
     }),
 );

api/api/v1/emojis/:id/index.ts

@@ -352,6 +352,6 @@ export default apiRoute((app) => {
 
         await db.delete(Emojis).where(eq(Emojis.id, id));
 
-        return context.body(null, 204);
+        return context.text("", 204);
     });
 });

api/api/v1/notifications/:id/dismiss.ts

@@ -68,6 +68,6 @@ export default apiRoute((app) =>
             dismissed: true,
         });
 
-        return context.body(null, 200);
+        return context.text("", 200);
     }),
 );

api/api/v1/notifications/clear/index.ts

@@ -47,6 +47,6 @@ export default apiRoute((app) =>
 
         await user.clearAllNotifications();
 
-        return context.body(null, 200);
+        return context.text("", 200);
     }),
 );

api/api/v1/notifications/destroy_multiple/index.ts

@@ -60,6 +60,6 @@ export default apiRoute((app) =>
 
         await user.clearSomeNotifications(ids);
 
-        return context.body(null, 200);
+        return context.text("", 200);
     }),
 );

api/api/v1/roles/:id/index.ts

@@ -226,7 +226,7 @@ export default apiRoute((app) => {
             visible,
         });
 
-        return context.body(null, 204);
+        return context.text("", 204);
     });
 
     app.openapi(routeDelete, async (context) => {
@@ -261,6 +261,6 @@ export default apiRoute((app) => {
 
         await role.delete();
 
-        return context.body(null, 204);
+        return context.text("", 204);
     });
 });

api/api/v2/filters/:id/index.ts

@@ -343,6 +343,6 @@ export default apiRoute((app) => {
             .delete(Filters)
             .where(and(eq(Filters.userId, user.id), eq(Filters.id, id)));
 
-        return context.body(null, 204);
+        return context.text("", 204);
     });
 });

api/messaging/index.ts

@@ -43,6 +43,6 @@ export default apiRoute((app) =>
         getLogger(["federation", "messaging"])
             .info`Received message via ${chalk.bold("Instance Messaging")}:\n${content}`;
 
-        return context.body(null, 200);
+        return context.text("", 200);
     }),
 );

plugins/openid/routes/sso/:id/index.ts

@@ -201,7 +201,7 @@ export default (plugin: PluginType): void => {
                     .delete(OpenIdAccounts)
                     .where(eq(OpenIdAccounts.id, account.id));
 
-                return context.body(null, 204);
+                return context.text("", 204);
             },
         );
     });