fix(federation): 🐛 Fix new notes being federated to ALL remote users, regardless of visibility

classes/functions/federation.ts

@@ -2,9 +2,6 @@ import type { Undo } from "@lysand-org/federation/types";
 import { config } from "config-manager";
 import type { User } from "~/packages/database-interface/user";
 
-export const localObjectUri = (id: string) =>
-    new URL(`/objects/${id}`, config.http.base_url).toString();
-
 export const undoFederationRequest = (undoer: User, uri: string): Undo => {
     const id = crypto.randomUUID();
     return {

packages/database-interface/note.ts

@@ -1,4 +1,5 @@
 import { idValidator } from "@/api";
+import { localObjectUri } from "@/constants";
 import { proxyUrl } from "@/response";
 import { sanitizedHtmlStrip } from "@/sanitization";
 import { sentry } from "@/sentry";
@@ -29,7 +30,6 @@ import {
     type Application,
     applicationToApi,
 } from "~/classes/functions/application";
-import { localObjectUri } from "~/classes/functions/federation";
 import {
     type StatusWithRelations,
     contentToHtml,
@@ -230,7 +230,7 @@ export class Note extends BaseInterface<typeof Notes, StatusWithRelations> {
                     relationships: {
                         where: (relationship, { eq, and }) =>
                             and(
-                                eq(relationship.subjectId, Users.id),
+                                eq(relationship.subjectId, this.data.authorId),
                                 eq(relationship.following, true),
                             ),
                     },

utils/constants.ts

@@ -2,3 +2,6 @@ import { config } from "config-manager";
 
 export const oauthRedirectUri = (issuer: string) =>
     new URL(`/oauth/sso/${issuer}/callback`, config.http.base_url).toString();
+
+export const localObjectUri = (id: string) =>
+    new URL(`/objects/${id}`, config.http.base_url).toString();