versia-pub/server
2
0
Fork 0
mirror of https://github.com/versia-pub/server.git synced 2025-12-06 08:28:19 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(federation): Send Undos to the followee when unfollowing

Browse source
This commit is contained in:
Gaspard Wierzbinski 2024-08-02 18:28:47 +02:00 committed by GitHub
parent 1368dac77e d2113e349f
commit 838debec25
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 43 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
packages/database-interface/user.ts
View file

@ -48,6 +48,7 @@ import {
Users,
} from "~/drizzle/schema";
import { type Config, config } from "~/packages/config-manager";
import { undoFederationRequest } from "../../classes/functions/federation.ts";
import { BaseInterface } from "./base";
import { Emoji } from "./emoji";
import { Instance } from "./instance";
@ -254,6 +255,46 @@ export class User extends BaseInterface<typeof Users, UserWithRelations> {
return foundRelationship;
}
async unfollow(followee: User, relationship: Relationship) {
if (followee.isRemote()) {
// TODO: This should reschedule for a later time and maybe notify the server admin if it fails too often
const { ok } = await this.federateToUser(
undoFederationRequest(
this,
new URL(
`/follows/${relationship.id}`,
config.http.base_url,
).toString(),
),
followee,
);
if (!ok) {
return false;
}
} else if (!this.data.isLocked) {
if (relationship.data.following) {
await db.insert(Notifications).values({
accountId: followee.id,
type: "unfollow",
notifiedId: this.id,
});
} else {
await db.insert(Notifications).values({
accountId: followee.id,
type: "cancel-follow",
notifiedId: this.id,
});
}
}
await relationship.update({
following: false,
});
return true;
}
static async webFinger(
manager: FederationRequester,
username: string,

6
server/api/api/v1/accounts/:id/unfollow.ts
View file

@ -57,10 +57,8 @@ export default (app: Hono) =>
otherUser,
);
if (foundRelationship.data.following) {
await foundRelationship.update({
following: false,
});
if (!(await self.unfollow(otherUser, foundRelationship))) {
return errorResponse("Failed to unfollow user", 500);
}
return jsonResponse(foundRelationship.toApi());