From 9d88fdbe53a648d99fc26d1be88c28f600c547c9 Mon Sep 17 00:00:00 2001 From: Jesse Wierzbinski Date: Tue, 31 Dec 2024 17:35:27 +0100 Subject: [PATCH] ci: :recycle: Make tests, linting and checks pass before build is run --- .github/workflows/check.yml | 6 +----- .github/workflows/docker.yml | 13 ++++++++++++- .github/workflows/lint.yml | 6 +----- .github/workflows/tests.yml | 6 +----- 4 files changed, 15 insertions(+), 16 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 92f7b990..51e3b3d5 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -1,11 +1,7 @@ name: Check Types on: - push: - branches: ["*"] - pull_request: - # The branches below must be a subset of the branches above - branches: ["main"] + workflow_call: jobs: tests: diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 85bd9105..4b5c8648 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -2,14 +2,25 @@ name: Build Docker Images on: push: - branches: ["main"] + branches: ["*"] # Publish semver tags as releases. tags: ["v*.*.*"] pull_request: branches: ["main"] jobs: + lint: + uses: ./.github/workflows/lint.yml + + check: + uses: ./.github/workflows/check.yml + + tests: + uses: ./.github/workflows/tests.yml + build: + if: ${{ success() }} + needs: [lint, check, tests] runs-on: ubuntu-latest permissions: contents: read diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 62511425..eb8a3b1a 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,11 +1,7 @@ name: Lint & Format on: - push: - branches: ["*"] - pull_request: - # The branches below must be a subset of the branches above - branches: ["main"] + workflow_call: jobs: tests: diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f6104e2e..29a01b61 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -1,11 +1,7 @@ name: Tests on: - push: - branches: ["*"] - pull_request: - # The branches below must be a subset of the branches above - branches: ["main"] + workflow_call: jobs: tests: